Fc to STG translation 1st version #8
+2,531
−559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gertjan423
reviewed
Apr 21, 2021
| return (ctx_ext, FcBind x ty ab) | ||
|
|
||
| -- | Type check applicaton of a list of terms to a term | ||
| tcFcOptTmApp :: FcOptTerm -> [FcOptTerm] -> FcM (FcType, FcResTerm) |
There was a problem hiding this comment.
This function looks really painful.... I don't really have any constructive feedback or improvements though....
Optimizer/FcTypeChecker.hs
Outdated
|
|
||
|
|
||
|
|
||
| tcFcResBind :: FcResBind -> FcM SBind |
There was a problem hiding this comment.
What is this function supposed to do?
Optimizer/FcTypes.hs
Outdated
| Datatypes representing the System F AST, with supporting functions and smart constructors. | ||
| System F syntax is split into two phases: | ||
| - Optimiser phase, marked with the @Opt type. These implement "vanilla" system F as it is most commonly seen. | ||
| - Preprocessed phase, marked with the @Pre type. This variant is preprocessed to be as easily translated into STG as possible. |
There was a problem hiding this comment.
This name needs to be updated?
Tests/Test5.hs
Outdated
| @@ -0,0 +1,11 @@ | |||
| -- * Simple test for using primitives | |||
There was a problem hiding this comment.
You should probably add some more tests later on.
stormeuh
changed the title
Gertjan423
approved these changes
May 12, 2021
Backend/STGTypes.hs
Outdated
| = MkAAlts [SAAlt] SDefAlt -- ^ ADT alternatives | ||
| | MkPAlts [SPAlt] SDefAlt -- ^ Primitive alternatives | ||
| = SAAlts [SAAlt] --SDefAlt -- ^ ADT alternatives | ||
| | SPAlts [SPAlt] --SDefAlt -- ^ Primitive alternatives |
There was a problem hiding this comment.
I don't understand this change. Why did you drop the SDefAlt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.