This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Remove the filter drawer. #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabhub
suggested changes
Jun 13, 2018
src/app/config/globalSettings.js
Outdated
| @@ -18,4 +18,10 @@ globalSettings.ENABLE_UNIQUE_CAT = true; | |||
| */ | |||
| globalSettings.DEFAULT_ACTIVE_CATEGORIES = [globalSettings.DEFAULT_ACTIVE_CATEGORY]; | |||
|
|
|||
| /** | |||
| * The new user interface aims at being simpler and more intuitive, making most | |||
| * filters more accessible. This filter drawer is not useful anymore. | |||
There was a problem hiding this comment.
Could you please also add a TODO comment about deleting all the deadcode concerning this obsolete feature ?
There was a problem hiding this comment.
@mabhub : I thought it was a good thing to keep it, as reactivating it is as simple as removing this override.
If we're sure we'll never ever need it in the future though, we could delete everything related to it.
Your opinion?
There was a problem hiding this comment.
@mabhub : Changed comments a bit to try to improve explanations. Better?
mabhub
approved these changes
Jun 13, 2018
src/app/config/globalSettings.js
Outdated
| @@ -18,4 +18,10 @@ globalSettings.ENABLE_UNIQUE_CAT = true; | |||
| */ | |||
| globalSettings.DEFAULT_ACTIVE_CATEGORIES = [globalSettings.DEFAULT_ACTIVE_CATEGORY]; | |||
|
|
|||
| /** | |||
| * The new user interface aims at being simpler and more intuitive, making most | |||
| * filters more accessible. This filter drawer is not useful anymore. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.