fix(Notifications): icons on flatpak #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #426
On flatpak, desktop notification would miss the user avatar. This is due to a bug with the way we set it and the sandbox.
Once notifications are sent, they cannot be modified so the icon has to be ready before sending it. As to avoid delaying them due to downloading the icon, we create a FileIcon with a remote file pointing to the avatar. That however doesn't work on flatpak and would result in notifications never being sent #382. As a workaround, I disabled the icons on flatpak.
This has been reported to the portal and the only solution is downloading the icon in advance. This is what this PR does, it utulizes the image helper so there's cache and sends the notification when the image is done. (only on flatpak, the native versions uses the original solution)