-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network cleanup #616
Conversation
and get rid of abstrac cache
Libsoup does in fact hit the cache, or at least the logger claims so. I simplified the API by getting rid of "is_loaded" and instead kept track of it locally. It also takes care of blurhash too. If a blurhash is provided, it will idly decode it and return it if the image hasn't loaded yet. |
nothingburger unused
another nothingburger
msg was only used for getting the header in timeline another nothingburger
I think that last commit fixed #136 🤷 needs more testing |
while this shouldn't(?) be happening, it occurs sometimes
it caches anything that's cacheable, not only media
memory leaks out of your control? more likely than you think. FlowBox#bind_model caused a memory leak, use helper functions instead
... memory leak with FlowBox#bind_model 🤷 used helper functions instead |
as the preview one would be removed by the time it's actually done
…manually-caching
I'll go ahead and merge it. There's no way to find out what might be wrong unless it starts getting used outside of this PR |
I used it for some time and it worked fine. |
It has some problems here and there, especially:
Overall this change is actually positive despite its shortcomings. From a user standpoint, it saves on bandwidth by caching images and metadata locally ( Thanks for testing it as always 💛🎺 |
libsoup can handle caching. Caching entities was more of a headache than helpful (any changes wouldn't reflect or would reflect globally). Caching images in memory for x amount of time is wasteful.
Following tootle discussions it seems that it was implemented because libsoup's wasn't reliable. Tuba migrated to libsoup3 however which might have fixed it.
TODO:
Check if cache actually works reliablyRemove abstract cache altogetherCache blurhashes?clear cache on close?fix: #136