-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MediaViewer): ScaleRevealer #602
Conversation
Co-authored-by: Marco Melorio <[email protected]> Co-authored-by: Kévin Commaille <[email protected]>
I like it a lot, well done! However, I would prefer the background not to be semi transparent because the content visible behind the image distracts from the image and makes the controls less noticeable. BTW, is there a chance for the media viewer to have two-clicks-to-zoom-in but one-click-to-close behavior, so I don't have to click that small < icon every time? :) |
Same, that wasn't the intention but I left it at that when I opened the PR since there's still a lot to do. This is far from done!
The goal is to port over Fractal's behavior which allows you to "drag" the image away to dismiss the media viewer, not sure how it will turn out however as Tuba's media viewer is a bit more complex (with the carousel and the mixed video and images etc) |
Kooha-2023-10-14-01-13-48.mp4It should be close to done now, just some small paper cuts, let me know if you see anything wrong! It's not only the animation, you should now also be able to dismiss it by dragging it vertically as shown in the video above! |
Ported ScaleRevealer from Fractal
Very WIP as the way the media viewer is displayed changed. The style difference in the recording is not on purpose. Media Viewer API needs a refactor asap.
The animation looks really nice!
Kooha-2023-10-13-01-54-15.mp4
TODO:
Refactor media viewerkind-ofadd commentadd other animationsmake sure the mediaviewer headerbar follows the animationswipe opacity of floating buttons and carousel indicator dots