Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MediaViewer): ScaleRevealer #602

Merged
merged 13 commits into from
Oct 15, 2023
Merged

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Oct 12, 2023

Ported ScaleRevealer from Fractal

Very WIP as the way the media viewer is displayed changed. The style difference in the recording is not on purpose. Media Viewer API needs a refactor asap.

The animation looks really nice!

Kooha-2023-10-13-01-54-15.mp4

TODO:

  • Refactor media viewer kind-of
  • add comment
  • add other animations
  • make sure the mediaviewer headerbar follows the animation
  • swipe opacity of floating buttons and carousel indicator dots

Co-authored-by: Marco Melorio <[email protected]>
Co-authored-by: Kévin Commaille <[email protected]>
@LukaszH77
Copy link
Contributor

I like it a lot, well done! However, I would prefer the background not to be semi transparent because the content visible behind the image distracts from the image and makes the controls less noticeable.

BTW, is there a chance for the media viewer to have two-clicks-to-zoom-in but one-click-to-close behavior, so I don't have to click that small < icon every time? :)

@GeopJr
Copy link
Owner Author

GeopJr commented Oct 13, 2023

I would prefer the background not to be semi transparent because the content visible behind the image distracts from the image and makes the controls less noticeable.

Same, that wasn't the intention but I left it at that when I opened the PR since there's still a lot to do. This is far from done!

BTW, is there a chance for the media viewer to have two-clicks-to-zoom-in but one-click-to-close behavior, so I don't have to click that small < icon every time? :)

The goal is to port over Fractal's behavior which allows you to "drag" the image away to dismiss the media viewer, not sure how it will turn out however as Tuba's media viewer is a bit more complex (with the carousel and the mixed video and images etc)

@GeopJr
Copy link
Owner Author

GeopJr commented Oct 13, 2023

Kooha-2023-10-14-01-13-48.mp4

It should be close to done now, just some small paper cuts, let me know if you see anything wrong!

It's not only the animation, you should now also be able to dismiss it by dragging it vertically as shown in the video above!

@GeopJr GeopJr marked this pull request as ready for review October 14, 2023 22:38
@GeopJr GeopJr merged commit a3b3323 into main Oct 15, 2023
5 checks passed
@GeopJr GeopJr deleted the feat/mediaviewer/scalerevealer branch October 15, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants