Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Clicking outside of an image should close it #148

Open
2 of 4 tasks
forteller opened this issue Apr 2, 2023 · 2 comments
Open
2 of 4 tasks

[Request]: Clicking outside of an image should close it #148

forteller opened this issue Apr 2, 2023 · 2 comments
Labels
designer input needed enhancement New feature or request mediaviewer Mediaviewer related issue

Comments

@forteller
Copy link

Describe the request

This is very natural and default in many apps. Thanks!

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@forteller forteller added the enhancement New feature or request label Apr 2, 2023
@GeopJr GeopJr added the mediaviewer Mediaviewer related issue label Apr 4, 2023
@GeopJr GeopJr mentioned this issue Jul 11, 2023
4 tasks
@GeopJr
Copy link
Owner

GeopJr commented Jul 13, 2023

I don't feel that confident about this. The media viewer is not a modal (like Mastodon Web) but a different view (like Mastodon Mobile).

It's closer to this:
image

Than this:
image

There's also the question of sizing. Currently the images expand, taking as much space as possible while keeping aspect ratio. That makes zooming a bit more complex but it results in 99% of users not having to use zoom at all to view images. Having the images be a static size or having enough padding around them as "blank space for dismissing" would require all users to use the zoom functions which is not ideal (and disabled on videos/gifs/audio).

Screencast.from.2023-07-13.05-07-24.webm

Note that Tuba's media viewer is not meant to replace your host's. It's meant to view/play multiple formats without opening them externally (images, videos, audio).

This needs more thought.

cc: @eobet

@eobet
Copy link

eobet commented Jul 21, 2023

I like both clicking on the background and swiping down to close the media as suggested here by @CaptainMorgan12.

As mentioned both here and in that other issue, many other apps use both interactions and the more interactions possible to achieve the same thing, the less pain points new users encounter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
designer input needed enhancement New feature or request mediaviewer Mediaviewer related issue
Projects
None yet
Development

No branches or pull requests

3 participants