Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Zoomed media UX #369

Closed
2 of 4 tasks
eobet opened this issue Jul 11, 2023 · 8 comments · Fixed by #380
Closed
2 of 4 tasks

[Request]: Zoomed media UX #369

eobet opened this issue Jul 11, 2023 · 8 comments · Fixed by #380
Labels
enhancement New feature or request

Comments

@eobet
Copy link

eobet commented Jul 11, 2023

Describe the request

The media lightbox/darkbox has a very bare bones UX.

For example:

  • You can't double click on it to toggle zoom.
  • You can't click on the background to close it out.

It took me quite some time to notice the very tiny zoom icon in the bottom right corner too, and if you're into keystroke analysis, using it is quite an operation (with the very small target increasing the cost).

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@eobet eobet added the enhancement New feature or request label Jul 11, 2023
@eobet eobet changed the title [Request]: Touchpad gesture pinch zoom support for media [Request]: Zoomed media UX Jul 11, 2023
@eobet
Copy link
Author

eobet commented Jul 11, 2023

Noticed that the original core issue I posted about was a duplicate of this (but the two UX pain points I describe actually don't have anything to do with the touchpad per se):

#264

@GeopJr
Copy link
Owner

GeopJr commented Jul 11, 2023

Thanks for raising this issue!

The media lightbox/darkbox has a very bare bones UX.

The design of the media viewer is close to Loupe (the soon-to-be default image viewer on GNOME) & Fractal so users have a similar experience between them. If there are more concerns or suggestions (apart from the ones listed in the OP) I'd love to hear them but if they are too far off Loupe's or Fractal's design/UX I'll probably have to decline.

You can't double click on it to toggle zoom.

I'll see about this but it's a bit tricky as there are zoom steps. Should double click zoom in one step or more? Should double clicking again zoom in another step or zoom out?

FWIW, Loupe toggles fullscreen on double click.

You can't click on the background to close it out.

duplicate of #148

It took me quite some time to notice the very tiny zoom icon in the bottom right corner too

Would changing the background to something lighter than #000 on dark mode help distinguish the floating buttons?

if you're into keystroke analysis, using it is quite an operation (with the very small target increasing the cost).

I'm not, would you mind elaborating?

Noticed that the original core issue I posted about

If the original issue was about pinch-to-zoom in general, Tuba has that. The linked issue is about it not matching Loupe's 1:1

@eobet
Copy link
Author

eobet commented Jul 11, 2023

Keystroke analysis is breaking down each step of an interaction into it's basic parts and measuring where the user spends most of their time.

I don't think backgrounds or even the size of those zoom buttons would help, because even if that reduces the search step (where the user looks for the button), the move step is still very long (especially in a narrow window docked to the side of the desktop, the cursor has to be moved a very long way since the user's eyes and cursor are probably focused more to the middle of the display), and then you have to click that very small area (which is increasingly difficult in proportion to how long the mouse cursor had to travel).

Placing the zoom buttons centered under the image would be better, but then they might not be in the same place depending on the aspect ratio of the image.

Anyway, I'd settle for one zoom step for the double click, which is why I said "zoom toggle". Different zoom steps is an advanced feature which I would reserve for those zoom buttons.

Together with clicking in the background to close the lightbox, a double click to zoom in, another to zoom out, would eliminate all of the searching and most of the mouse travel in a keystroke analysis.

@GeopJr
Copy link
Owner

GeopJr commented Jul 13, 2023

Keystroke analysis is breaking down each step of an interaction into it's basic parts and measuring where the user spends most of their time.

I don't think backgrounds or even the size of those zoom buttons would help, because even if that reduces the search step (where the user looks for the button), the move step is still very long (especially in a narrow window docked to the side of the desktop, the cursor has to be moved a very long way since the user's eyes and cursor are probably focused more to the middle of the display), and then you have to click that very small area (which is increasingly difficult in proportion to how long the mouse cursor had to travel).

Placing the zoom buttons centered under the image would be better, but then they might not be in the same place depending on the aspect ratio of the image.

Thanks for the info!

FWIW, there are buttons to go back/forwards on the left side when there are multiple attachments open. Centering, while possible, it probably won't look good when the navigation buttons are visible.

While I understand your concern, matching Loupe (the soon-to-be default image viewer on GNOME) and Fractal should decrease the help test by providing a familiar pattern

(screenshot of Loupe)
image

Perhaps providing more shortcuts might be a better middle ground (ctrl++, ctrl+MouseWheelUp (and double clicking of course))?

@eobet
Copy link
Author

eobet commented Jul 13, 2023

There is one very important difference between the screenshot you posted and what I'm seeing in Tuba today:

There a large, black circles behind the plus and minus buttons making them much larger. On my desktop, the background in the Tuba lightbox seems black, rendering those circles invisible which effectively shrinks down the button sizes to being uncomfortably small.

@LukaszH77
Copy link
Contributor

What version are you using? On my desktop, the current version from the main git branch looks like this:

obraz

@eobet
Copy link
Author

eobet commented Jul 13, 2023

You can see how mine looks in the video I posted to the issue I linked in my first reply here.

Depending on my laptop auto brightness, it's very, very dark.

I'm using Nobara from their default Gnome variant, so it is my understanding that this is the default Gnome look and feel. If this is a system default design, and there is a better place to provide feedback, I'd be interested in learning about it. The Gnome Gitlab is quite intimidating.

@LukaszH77
Copy link
Contributor

Mine was so bright compared to yours, because I was using the light style. With the dark style on, the buttons are still visible, but definitely not as good as they were before.

obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants