Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation within bezier_curve.cc #796

Conversation

danieldouglas92
Copy link
Contributor

A little more documentation could probably be added around the section of code where the side of the line that each control point lies on is calculated, but I wanted to open this for now to get feedback on what I wrote.

Copy link

github-actions bot commented Jan 20, 2025

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.117 ± 0.011 (s=412) 1.117 ± 0.009 (s=396) -0.2% .. +0.2%
Slab interpolation curved simple none 1.123 ± 0.011 (s=407) 1.124 ± 0.012 (s=397) -0.1% .. +0.4%
Spherical slab interpolation simple none 1.095 ± 0.009 (s=422) 1.095 ± 0.008 (s=402) -0.2% .. +0.2%
Slab interpolation simple curved CMS 1.163 ± 0.010 (s=424) 1.163 ± 0.011 (s=353) -0.2% .. +0.2%
Spherical slab interpolation simple CMS 1.442 ± 0.012 (s=305) 1.442 ± 0.012 (s=322) -0.2% .. +0.2%
Spherical fault interpolation simple none 1.101 ± 0.009 (s=391) 1.101 ± 0.008 (s=429) -0.2% .. +0.1%
Cartesian min max surface 2.540 ± 0.032 (s=182) 2.537 ± 0.016 (s=175) -0.5% .. +0.2%
Spherical min max surface 7.180 ± 0.072 (s=63) 7.170 ± 0.079 (s=65) -0.8% .. +0.5%

@danieldouglas92 danieldouglas92 force-pushed the add_documentation_to_bezier_curve branch from b7f53ed to f6f87d1 Compare January 21, 2025 19:37
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MFraters MFraters merged commit 087cef5 into GeodynamicWorldBuilder:main Jan 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants