Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2D index for data #788

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

Djneu
Copy link
Contributor

@Djneu Djneu commented Jan 20, 2025

This is a very small change that updates the data output indexes for compositions in 2D.

Copy link

github-actions bot commented Jan 20, 2025

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.125 ± 0.015 (s=409) 1.125 ± 0.010 (s=393) -0.3% .. +0.2%
Slab interpolation curved simple none 1.120 ± 0.011 (s=409) 1.119 ± 0.010 (s=397) -0.3% .. +0.2%
Spherical slab interpolation simple none 1.097 ± 0.009 (s=413) 1.097 ± 0.009 (s=410) -0.2% .. +0.2%
Slab interpolation simple curved CMS 1.163 ± 0.010 (s=390) 1.163 ± 0.010 (s=386) -0.2% .. +0.2%
Spherical slab interpolation simple CMS 1.441 ± 0.011 (s=318) 1.443 ± 0.012 (s=308) -0.1% .. +0.4%
Spherical fault interpolation simple none 1.101 ± 0.009 (s=411) 1.104 ± 0.009 (s=408) +0.0% .. +0.4%
Cartesian min max surface 2.540 ± 0.041 (s=173) 2.540 ± 0.017 (s=184) -0.4% .. +0.4%
Spherical min max surface 7.159 ± 0.078 (s=61) 7.172 ± 0.066 (s=67) -0.4% .. +0.8%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for finding this bug! Could you update the test results?

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@MFraters MFraters merged commit 0da29dd into GeodynamicWorldBuilder:main Jan 21, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants