Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04_adding_first_tectonic_feature.md #559

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

jdannberg
Copy link
Contributor

fix typo

@gassmoeller gassmoeller added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a01bf98) 93.54% compared to head (cb745fd) 93.54%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          92       92           
  Lines        6340     6340           
=======================================
  Hits         5931     5931           
  Misses        409      409           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01bf98...cb745fd. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.027 ± 0.003 (s=436) 1.030 ± 0.003 (s=441) +0.3% .. +0.4%
Slab interpolation curved simple none 1.028 ± 0.004 (s=442) 1.027 ± 0.003 (s=437) -0.2% .. -0.0%
Spherical slab interpolation simple none 1.262 ± 0.006 (s=373) 1.261 ± 0.006 (s=343) -0.2% .. +0.0%
Slab interpolation simple curved CMS 1.095 ± 0.005 (s=412) 1.098 ± 0.005 (s=411) +0.1% .. +0.3%
Spherical slab interpolation simple CMS 1.860 ± 0.007 (s=246) 1.856 ± 0.004 (s=241) -0.3% .. -0.1%
Spherical fault interpolation simple none 1.274 ± 0.005 (s=351) 1.273 ± 0.004 (s=358) -0.2% .. +0.0%
Cartesian min max surface 2.388 ± 0.042 (s=202) 2.388 ± 0.028 (s=177) -0.5% .. +0.5%
Spherical min max surface 7.342 ± 0.022 (s=62) 7.355 ± 0.035 (s=63) -0.1% .. +0.4%

@gassmoeller gassmoeller merged commit ceb6a89 into main Feb 13, 2024
55 of 57 checks passed
@gassmoeller gassmoeller deleted the another-typo branch February 13, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants