re-enabling 2D for chunk. not clear why this option was removed.

[mibillen]

This option existed before May 2023. It is not clear why it was removed and the assert added. However, Magali and Becky both use this option in the previous version (0.5 to check input structure before running in Aspect), without any problems and can't change to the new version without it. So, since we don't currently know what the problem is, I have removed the assert for now to allow the 2D option to be used with the chunk option and the grid input file.

[gassmoeller]

Menno will have to decide on this PR (I think you discussed it with him), but I would suggest to delete the line completely if you are not sure why it was introduced in the first place. Leaving commented code is a recipe for slowly cluttering the whole code with untrustworthy and outdated information.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b72ce04) 93.49% compared to head (4372832) 93.54%.
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   93.49%   93.54%   +0.05%     
==========================================
  Files          92       92              
  Lines        6346     6340       -6     
==========================================
- Hits         5933     5931       -2     
+ Misses        413      409       -4     

Files	Coverage Δ
source/gwb-grid/main.cc	46.29% <ø> (+0.11%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72ce04...4372832. Read the comment docs.

[github-actions]

Benchmark	Main	Feature	Difference (99.9% CI)
Slab interpolation simple none	1.024 ± 0.004 (s=440)	1.025 ± 0.004 (s=441)	-0.0% .. +0.2%
Slab interpolation curved simple none	1.028 ± 0.005 (s=462)	1.029 ± 0.005 (s=416)	+0.0% .. +0.2%
Spherical slab interpolation simple none	1.259 ± 0.004 (s=336)	1.263 ± 0.005 (s=380)	+0.2% .. +0.4%
Slab interpolation simple curved CMS	1.096 ± 0.002 (s=399)	1.098 ± 0.003 (s=424)	+0.1% .. +0.2%
Spherical slab interpolation simple CMS	1.858 ± 0.005 (s=244)	1.862 ± 0.006 (s=242)	+0.1% .. +0.3%
Spherical fault interpolation simple none	1.273 ± 0.007 (s=369)	1.275 ± 0.005 (s=340)	+0.1% .. +0.3%
Cartesian min max surface	2.430 ± 0.022 (s=179)	2.428 ± 0.022 (s=194)	-0.4% .. +0.2%
Spherical min max surface	7.342 ± 0.018 (s=69)	7.370 ± 0.098 (s=56)	-0.3% .. +1.0%

[MFraters]

Yes, I agree, please delete the line. Otherwise good to go. If we find an issue in the future, we can document directly what the issue is and/or directly try to fix it.