Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwb-grid: rework help text, add version info #550

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Feb 13, 2024

FYI: @mibillen

Copy link
Contributor

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner to me.

@gassmoeller gassmoeller added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 13, 2024
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! One small request for an addition, otherwise good to go.

<< WorldBuilder::Version::MINOR << "."
<< WorldBuilder::Version::PATCH << "."
<< WorldBuilder::Version::LABEL
<< std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are at it, can you also add the git hash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tjhei
Copy link
Contributor Author

tjhei commented Feb 13, 2024

I will need to update some test output, I think.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1ae31ff) 93.49% compared to head (f5a2f34) 93.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   93.49%   93.54%   +0.05%     
==========================================
  Files          92       92              
  Lines        6346     6340       -6     
==========================================
- Hits         5933     5931       -2     
+ Misses        413      409       -4     
Files Coverage Δ
source/gwb-grid/main.cc 46.29% <0.00%> (+0.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae31ff...f5a2f34. Read the comment docs.

Copy link

github-actions bot commented Feb 13, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.019 ± 0.006 (s=467) 1.021 ± 0.005 (s=418) +0.1% .. +0.3%
Slab interpolation curved simple none 1.025 ± 0.004 (s=432) 1.026 ± 0.004 (s=448) -0.0% .. +0.2%
Spherical slab interpolation simple none 1.262 ± 0.004 (s=368) 1.261 ± 0.003 (s=348) -0.1% .. +0.0%
Slab interpolation simple curved CMS 1.095 ± 0.005 (s=394) 1.095 ± 0.004 (s=430) -0.1% .. +0.1%
Spherical slab interpolation simple CMS 1.856 ± 0.005 (s=236) 1.856 ± 0.005 (s=251) -0.1% .. +0.1%
Spherical fault interpolation simple none 1.269 ± 0.003 (s=354) 1.273 ± 0.005 (s=357) +0.2% .. +0.3%
Cartesian min max surface 2.364 ± 0.022 (s=197) 2.365 ± 0.023 (s=186) -0.3% .. +0.4%
Spherical min max surface 7.395 ± 0.038 (s=65) 7.393 ± 0.014 (s=59) -0.3% .. +0.2%

@MFraters MFraters merged commit 60ebb0b into GeodynamicWorldBuilder:main Feb 13, 2024
32 of 34 checks passed
@tjhei tjhei deleted the gwb-grid-help branch February 13, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants