-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gwb-grid: rework help text, add version info #550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! One small request for an addition, otherwise good to go.
<< WorldBuilder::Version::MINOR << "." | ||
<< WorldBuilder::Version::PATCH << "." | ||
<< WorldBuilder::Version::LABEL | ||
<< std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we are at it, can you also add the git hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I will need to update some test output, I think. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 93.49% 93.54% +0.05%
==========================================
Files 92 92
Lines 6346 6340 -6
==========================================
- Hits 5933 5931 -2
+ Misses 413 409 -4
Continue to review full report in Codecov by Sentry.
|
|
FYI: @mibillen