Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-diagram-fix - Fix diagram break lines '\n' #28

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

M-casado
Copy link
Collaborator

@M-casado M-casado commented Sep 10, 2024

Summary

Fixed line breaks (\n) in the diagram

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Motivation and Context

Some change in mermaid render made it so that \n are not interpreted as new lines, thus I replaced them with <br>

References

NA

Changes Introduced

  • Changed \n with <br>

Review

Just reviewed it myself in Mermaid.live and in the branch itself

Checklist:

General Compliance:

  • My changes follow the code style of this project (GDI SOP Style Guide) and the file naming conventions of the file accessioning proposal.
  • I have verified that all new updated content is accessible, including checking that all external references are readable (i.e., no broken links). These may include references to external resources that should be resolvable, and internal references among SOPs.
  • I have properly added this PR's changes to the repository CHANGELOG.md.

Only applicable if the PR includes new, or changes to, GDI SOPs (i.e., documents at sops/):

  • My SOP-related changes adhere to the Generic SOP Template, including format and required fields.
  • I have consulted the Charter, ISM, and ORR documents to ensure compliance.
  • I am complying with the established procedure for SOP creations and modifications, including respecting review phases and notifying needed contributors for reviews.

@M-casado M-casado added the bug Something isn't working label Sep 10, 2024
@M-casado M-casado requested a review from silviabah September 10, 2024 11:56
@M-casado M-casado self-assigned this Sep 10, 2024
@M-casado
Copy link
Collaborator Author

I double-checked in the diagram that it works. It's a minimal change anyway, so I will approve it on my own (😢 )

@M-casado M-casado merged commit 713dfd4 into main Sep 23, 2024
1 of 2 checks passed
@M-casado M-casado deleted the quick-diagram-fix branch September 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant