Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Art 11336 display dataset type #140

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

antoine-dorard-lnds
Copy link
Contributor

@antoine-dorard-lnds antoine-dorard-lnds commented Jan 13, 2025

Summary by Sourcery

New Features:

  • Display the dataset type as a facet on the search page.

Copy link
Contributor

sourcery-ai bot commented Jan 13, 2025

Reviewer's Guide by Sourcery

This pull request implements changes to display the dataset type in the CKAN user portal. It modifies the translation_utils.py and plugin.py files to include the dcat_type field, which represents the dataset type.

Class diagram showing the addition of dcat_type field

classDiagram
    class GdiUserPortalPlugin {
        +REPLACE_FIELDS: list
        +dcat_type: string
    }
    note for GdiUserPortalPlugin "Added dcat_type to REPLACE_FIELDS"

    class TranslationUtils {
        +DATASET_REPLACE_FIELDS: list
        +dcat_type: string
    }
    note for TranslationUtils "Added dcat_type to DATASET_REPLACE_FIELDS"
Loading

File-Level Changes

Change Details Files
Added dcat_type to the list of displayed fields.
  • Included the dcat_type field in the DATASET_REPLACE_FIELDS list in translation_utils.py.
  • Added the dcat_type field to the list of searchable fields in plugin.py.
ckanext/gdi_userportal/logic/action/translation_utils.py
ckanext/gdi_userportal/plugin.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @antoine-dorard-lnds - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@antoine-dorard-lnds antoine-dorard-lnds merged commit fa5f439 into main Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants