-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Art 11336 display dataset type #140
Conversation
Reviewer's Guide by SourceryThis pull request implements changes to display the dataset type in the CKAN user portal. It modifies the Class diagram showing the addition of dcat_type fieldclassDiagram
class GdiUserPortalPlugin {
+REPLACE_FIELDS: list
+dcat_type: string
}
note for GdiUserPortalPlugin "Added dcat_type to REPLACE_FIELDS"
class TranslationUtils {
+DATASET_REPLACE_FIELDS: list
+dcat_type: string
}
note for TranslationUtils "Added dcat_type to DATASET_REPLACE_FIELDS"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @antoine-dorard-lnds - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
New Features: