Skip to content

Commit

Permalink
fix(Dockerfile): use COPY instead of ADD for secure file handling (#130)
Browse files Browse the repository at this point in the history
Replaced ADD with COPY to align with Dockerfile best practices, ensuring explicit and secure file copying. Addresses issue #129 by preventing unintended behaviors such as remote URL downloads or archive extraction.

Co-authored-by: Hans-Chrstian <[email protected]>
  • Loading branch information
hcvdwerf and Hans-Chrstian authored Nov 20, 2024
1 parent dc82305 commit 5aa3ae1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion solr/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ USER root
RUN cp -R $SOLR_CONFIG_DIR/_default $SOLR_CONFIG_DIR/ckan

# Update the schema
ADD ./schema.xml $SOLR_SCHEMA_FILE
COPY ./schema.xml $SOLR_SCHEMA_FILE
RUN chmod 644 $SOLR_SCHEMA_FILE

USER solr
Expand Down

0 comments on commit 5aa3ae1

Please sign in to comment.