Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker #11

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Fix docker #11

merged 3 commits into from
Jun 17, 2024

Conversation

Fa8Bit
Copy link
Contributor

@Fa8Bit Fa8Bit commented Jun 3, 2024

No description provided.

@Fa8Bit Fa8Bit added the bug Something isn't working label Jun 3, 2024
@Fa8Bit Fa8Bit requested review from eisenmls and opourazar June 3, 2024 11:46
opourazar
opourazar reviewed Jun 3, 2024
View reviewed changes
Copy link

@opourazar opourazar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required changes to make the respective files working for development purposes.
NOTE: Some tests didn't run through.

@Fa8Bit
Copy link
Contributor Author

Fa8Bit commented Jun 14, 2024

Finished changes, can be merged, pls merge as "squash and merge"

eisenmls
eisenmls approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@eisenmls eisenmls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@eisenmls eisenmls merged commit e67c23c into main Jun 17, 2024
2 of 3 checks passed
@Fa8Bit Fa8Bit deleted the bugfix_docker branch July 21, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opourazar opourazar opourazar left review comments

@eisenmls eisenmls eisenmls approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fa8Bit @eisenmls @opourazar