Merge pull request #5 from Gamify-IT/maintenance/fix-sonar-warnings

Fix SonarQube warnings
Gamify-IT · Jul 12, 2022 · 050124a · 050124a
2 parents fc805d7 + 40b60b8
commit 050124a
Show file tree

Hide file tree

Showing 5 changed files with 256 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/App.vue b/src/App.vue
@@ -1,5 +1,5 @@
 <template>
-  <button class="btn btn-danger close-button" @click="closeMicroservice()"><i class="bi bi-x"></i></button>
+  <button class="btn btn-danger close-button" @click="closeMicroservice()"><em class="bi bi-x"></em></button>
   <enemy-button :git="git" :initCards="initCards" :onEnemyTurn="onEnemyTurn" ref="enemyButton"></enemy-button>
   <git-view-vue :git="git"></git-view-vue>
   <card-stack :git="git" :onError="onError" :turn="turn" ref="cardStack"></card-stack>
@@ -24,7 +24,6 @@ export default {
       turn: true,
     };
   },
-  mounted() {},
   methods: {
     initCards() {
       this.turn = true;

diff --git a/src/components/EnemyButton.vue b/src/components/EnemyButton.vue
@@ -29,14 +29,16 @@ export default {
       this.btnText = 'Finish your turn';
       this.initCards();
     },
-    async click() {
-      this.beforeClick();
-
+    fillCards() {
       while (this.cards.length !== 5) {
         const randomCard = getRandomCard();
         if (this.cards.filter((card) => card.command === randomCard.command).length >= 2) continue;
         this.cards.push(randomCard);
       }
+    },
+    async click() {
+      this.beforeClick();
+      this.fillCards();
 
       while (this.cards.length !== 0) {
         let cardUsed = false;
@@ -82,9 +84,6 @@ export default {
   transform: translate(-50%, 100px);
 }
 
-.enemy-button {
-}
-
 .score {
   color: black;
 }