Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abrobad #127

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Abrobad #127

merged 9 commits into from
Dec 4, 2024

Conversation

aqitya
Copy link
Contributor

@aqitya aqitya commented Nov 13, 2024

abrobad uni implementation

@aqitya
Abrobad
3b0a349 
abrobad uni implementation
@aqitya aqitya requested review from robertyishi and removed request for ddgarcia and MillerHollinger December 3, 2024 00:29
robertyishi
robertyishi requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@robertyishi robertyishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the SVG files seems to be accidentally modified and should probably be reverted. Everything else looks good

src/models/images/svg/3spot/h.svg Show resolved Hide resolved
@robertyishi robertyishi self-requested a review December 4, 2024 03:40
robertyishi
robertyishi approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@robertyishi robertyishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertyishi robertyishi self-requested a review December 4, 2024 05:43
robertyishi
robertyishi approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@robertyishi robertyishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@robertyishi robertyishi merged commit 78088b1 into GamesCrafters:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertyishi robertyishi robertyishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqitya @robertyishi