Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use build script instead of git submodule #34

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

nekomoto911
Copy link
Collaborator

@nekomoto911 nekomoto911 commented Nov 28, 2024

Use build script instead of git submodule to manage submodules for test.
The current submodules for test are too large, and when another Cargo project depending on this git repo, Cargo cannot skip downloading these submodules, even though they will not be used , which can slow down the project building speed.
Add --features update-test-submodule option to cargo test command if you want to synchronize these test submodules.
Modify the TestSubmodule config in build.rs if you want to update the version of the submodules.

@nekomoto911 nekomoto911 requested a review from AshinGau November 28, 2024 15:52
@nekomoto911 nekomoto911 force-pushed the cyx-dev branch 2 times, most recently from 7a3c3f7 to 49d4a6b Compare November 28, 2024 16:15
Copy link
Collaborator

@Richard1048576 Richard1048576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekomoto911 nekomoto911 merged commit 773c215 into main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants