fix: create the miner account if not exist #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekomoto911
reviewed
Nov 26, 2024
| @@ -624,6 +625,13 @@ where | |||
| } | |||
| info.balance = info.balance.saturating_add(U256::from(inc_rewards)); | |||
| balance = info.balance; | |||
| } else if inc_rewards != 0 { | |||
| result = Ok(Some(AccountInfo::new( | |||
There was a problem hiding this comment.
Is this enough? Should we create insert this new account into the cache?
There was a problem hiding this comment.
No need. write set will commit back into cache.
There was a problem hiding this comment.
Consider adding comments to explain what this temporary account is used for, as well as why nonce and code can be default values.
nekomoto911
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.