-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests and documentation for normalization of boolean values #277
Conversation
I don't understand these CI failures:
|
The CI failure is #278. |
Matches on `ConjMapView` encode the semantic meaning of the constructors.
907b231
to
9b76248
Compare
Rebased onto #283 for CI fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although the CI is failing now for an unrelated reason: the code uses ImportQualifiedPost
, which is only available in GHC 8.10 or later. We could drop support for GHC 8.8 to support this, although this might be better done in a separate patch.
Removed, thanks! |
ConjMap
newtype aroundBoolMap
for readability of pattern matches and type signaturesBoolMap