Add PowerPC support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignment This `KnownNat` constraint isn't used and will complicate things in a follow-up patch where we want to call `buildArgumentAssignment` from a place where a `KnownNat` constraint isn't readily available. Let's just remove this constraint.
langston-barrett
approved these changes
Jul 22, 2024
This was referenced Jul 23, 2024
RyanGlScott
force-pushed
the
t33-powerpc-support
branch
from
e5f0dbb to
dbeb692
Compare
This bumps the `macaw` submodule to bring in the changes from GaloisInc/macaw#401, which is a prerequisite to being able to support PowerPC in `stubs`. This also requires bumping the `crucible`, `elf-edit`, `llvm-pretty`, and `what4` submodules in order to construct a build plan that is consistent with the latest `macaw` commit. One step towards #33.
One step towards #33.
One step towards #33.
One step towards #33.
One step towards #33.
One step towards #33.
One step towards #33.
One step towards #33.
One step towards #33.
Doing so is actively harmful when adjusting the size of pointers, as `projectLLVM_bv` will throw an assertion failure if this happens. We now adjust pointer sizes in an alternative, non-assertion-failure–throwing fashion. After doing this, some functions in `Stubs.Override` (e.g., `bvToPtr`) no longer serve a useful purpose, so I went ahead and removed them. Fixes #41.
RyanGlScott
force-pushed
the
t33-powerpc-support
branch
from
dbeb692 to
42289dd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a collection of commits that add support for simulating PowerPC code in
stubs, thereby fixing #33.This is marked as a draft because it depends on upstream
macawchanges in GaloisInc/macaw#401, which have not landed yet.