Restore support for explicit type signatures on polymorphic functions #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typechecking updates some the AST elements with additional information, including Pattern, and some (but not all) of the code paths were discarding the updated Pattern. It's not clear if this was actually causing any real problems, but it's wrong and it seemed like a good idea to fix it before tinkering with patterns further. (which then didn't happen because the original approach to the upcoming stuff didn't work out, but anyway...)
sauclovian-g
force-pushed
the
2204-polymorphic-signatures
branch
from
45a4ad9 to
0a078e1
Compare
RyanGlScott
approved these changes
Jan 29, 2025
src/SAWScript/MGU.hs
Outdated
Comment on lines
895
to
898
| -- Get the free type variables found in a chain of Function Exprs. | ||
| inspectLambdaFTVs :: Expr -> TI (Expr, Map Name Pos) |
There was a problem hiding this comment.
Make sure to also document the meaning of the Expr that is returned here.
There was a problem hiding this comment.
Done (I squashed it in and force-pushed to reduce noise)
sauclovian-g
force-pushed
the
2204-polymorphic-signatures
branch
from
3faf447 to
4d87626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.