Bump the lmdb Python bindings to 1.6.2 to gain support for Python 3.13 #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauclovian-g
added
the
PR: dependency bump
RyanGlScott
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
LGTM assuming that CI passes. My educated guess is that the upgrade from lock-version 2.0 to 2.1 shouldn't impact much, as (I think) the groups just make it more obvious whether a dependency is installed by default ("main") or only when development dependencies are installed ("dev").
|
The thing I'd worry about is that it makes the lock file incompatible with someone else's older version of poetry that they'll then have to update. Hopefully this isn't a huge problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2178.