Correct the behavior of generalize in the typechecker #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to rebase this on top of the lmdb-python bump (should probably have done that the other way around, oops, too late now) then merge it. |
We do need to search the value environment for mentions of unification vars, because if we're nested inside several layers of declaration we could be referring to unification vars coming from an outer scope, and those shouldn't be forall-bound until we close off that scope. We also need to search the right hand side of typedefs for the same reason; this was previously wrong although it would be at least moderately difficult to step on. However, for named vars the names we should not bind are the _keys_ of the type name environment; those are the type vars that already exist. We don't allow random named type vars to float around any more, so that should always exclude all named type vars we have. (I haven't added an assertion for this, but perhaps I should have.) Fixes #2105.
sauclovian-g
force-pushed
the
2105-generalize
branch
from
27122f5 to
49b7bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2105.