Fix the dead links in the tutorials #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While www.musl-libc.org is still a valid domain name, it directs to a page without much content / redirecting you to musl.libc.org.
The previous link (to the 2009 format conventions for the SAT competition) has been dead for some time. The new link takes the reader directly to a description of the DIMACS CNF format, which is the most relevant part of the original link for the purposes of using SAW with external solvers.
This previously mistakenly linked to the `ctpop` function in Rust's std::intrinsics module.
Salsa20.cry is a _sibling_ of the `src/` directory, not a member of it.
RyanGlScott
reviewed
Dec 20, 2024
There was a problem hiding this comment.
This is great!
One remaining task: currently, the PDF versions of the tutorials are checked into git, so you'll need to regenerate the PDFs by going into each subdirectory and running make. (Ideally, we'd deploy this documentation automatically instead, but it's not quite at that point yet.)
|
@RyanGlScott It looks like the Rust tutorial PDF is not checked in to the repo currently -- shall I add it as part of this PR? |
|
Ah, indeed it isn't. In that case, no, I don't propose that we check in the Rust tutorial's PDF as part of this PR. |
RyanGlScott
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2168.