Use ocaml/setup-ocaml@v2 #1324
Closed
Use ocaml/setup-ocaml@v2 #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
commented
Jun 8, 2021
| @@ -20,25 +20,15 @@ jobs: | |||
| env: | |||
| COQ_VERSION: ${{ matrix.coq }} | |||
| # coq-bits claims to support < 4.10 only | |||
| OCAML_VERSION: 4.09.1 | |||
| OCAML_VERSION: 4.09.x | |||
There was a problem hiding this comment.
This allows you to always use the latest point release.
Comment on lines
-59
to
+50
| eval $(opam env) | ||
| coq_makefile -f _CoqProject -o Makefile.coq | ||
| make -j2 | ||
| opam exec -- coq_makefile -f _CoqProject -o Makefile.coq | ||
| opam exec -- make -j2 |
There was a problem hiding this comment.
It's recommended to use opam exec instead of eval $(opam env).
|
All of these points seem to have been addressed already at some point in the past three years. Sorry this never got handled directly. |
|
@sauclovian-g No worries. And it already has a new version: #2153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v2, the cache is enabled by default. Also, actions-ml is completely deprecated.