ChaChaPolyCryptolIETF: Return an Option in AEAD_CHACHA20_POLY1305_DECRYPT
#1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies over the changes made to the upstream `cryptol-specs` version of this spec in GaloisInc/cryptol-specs@2adbcf1. Co-authored-by: Ryan Scott <[email protected]>
This copies over the changes made to the upstream `cryptol-specs` version of this spec in GaloisInc/cryptol-specs@2966a9b. Co-authored-by: Ryan Scott <[email protected]>
…RYPT (GaloisInc/cryptol-specs#239) (This copies over the changes made to the upstream `cryptol-specs` version of this spec in GaloisInc/cryptol-specs@548ad3f as part of GaloisInc/cryptol-specs#240. This is in pursuit of the eventual goal of purging uses of the `(a, Bit)` Cryptol anti-pattern in favor of returning `Option` types, as described in GaloisInc/cryptol-specs#239.) Instead of returning `([m][8], Bit)`, where the `Bit` indicates whether the result is valid or not, we now make the `AEAD_CHACHA20_POLY1305_DECRYPT` function return an `Option`. We also introduce an `optFold` function to `OptionUtils` to factor out some repeatedly used code needed to post-process the decrypted results. This checks off one box in GaloisInc/cryptol-specs#239.
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
marsella
approved these changes
Feb 7, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies over changes made to the upstream
cryptol-specsversion of theChaChaPolyCryptolIETFspec, up to and including a change to make theAEAD_CHACHA20_POLY1305_DECRYPTfunction return anOption(as done in GaloisInc/cryptol-specs#240). This is in pursuit of the eventual goal of purging uses of the(a, Bit)Cryptol anti-pattern in favor of returningOptiontypes, as described in GaloisInc/cryptol-specs#239.)This checks off one box in GaloisInc/cryptol-specs#239.