Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add more comments, pursuant to previous changes #1794

Merged
merged 1 commit into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@ jobs:
- if: runner.os == 'Windows'
run: .github/wix.ps1

# Do not run this on forks. It isn't sufficient to check the pull
# request info because we might also be on master in a fork. It
# seems that you can't stop scheduled jobs from also running in
# forks. See https://github.com/orgs/community/discussions/16109.
- if: runner.os == 'Windows' && github.event.pull_request.head.repo.fork == false && github.repository_owner == 'GaloisInc'
shell: bash
env:
Expand All @@ -212,6 +216,10 @@ jobs:
OS_TAG: ${{ matrix.os }}
ARCH_TAG: ${{ runner.arch }}

# Do not run this on forks. It isn't sufficient to check the pull
# request info because we might also be on master in a fork. It
# seems that you can't stop scheduled jobs from also running in
# forks. See https://github.com/orgs/community/discussions/16109.
- if: github.event.pull_request.head.repo.fork == false && github.repository_owner == 'GaloisInc'
shell: bash
env:
Expand Down Expand Up @@ -413,6 +421,9 @@ jobs:
build-push-image:
runs-on: ubuntu-22.04
needs: [config]
# Do not run this on forks. It seems that you can't stop scheduled
# jobs from also running in forks. See
# https://github.com/orgs/community/discussions/16109.
if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || needs.config.outputs.release == 'true') && github.repository_owner == 'GaloisInc'
strategy:
fail-fast: false
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ jobs:
-p 'python3.withPackages (pp: [pp.sphinx pp.sphinx_rtd_theme])' \
--run 'make html'
build-pages-docs:
# Do not run this on forks:
# Do not run this on forks. It isn't sufficient to check the pull
# request info because we might also be on master in a fork. It
# seems that you can't stop scheduled jobs from also running in
# forks. See https://github.com/orgs/community/discussions/16109.
if: github.event.pull_request.head.repo.fork == false && github.repository_owner == 'GaloisInc'
runs-on: ubuntu-latest
# The public interface should then allow the user to browse the cryptol
Expand Down
Loading