Update modNameChunksText to match modNameToText behavior #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glguy
commented
Jan 23, 2025
There was a problem hiding this comment.
PR made to address the comment at GaloisInc/saw-script#2174 (comment)
I chatted with Iavor and this seems to be what the code should be doing.
glguy
force-pushed
the
glguy/modNameChunksText
branch
from
02f5f91 to
54f1387
Compare
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 23, 2025
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 23, 2025
RyanGlScott
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
I've updated GaloisInc/saw-script#2174 to use the changes from this PR, and the integration tests now pass! Thank you so much for fixing this.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 23, 2025
…Inc/cryptol#1783, and GaloisInc/cryptol#1791 This is a collection of `cryptol` submodule bumps that is squashed together in order to ensure that the SAW CI continues to pass with this commit: * GaloisInc/cryptol#1783 bumps Cryptol's lower version bounds on `simple-smt` to `>=0.9.8`, which requires updating SAW's `cabal.GHC-*.config` files accordingly. * GaloisInc/cryptol#1526 is brought along for the ride as part of this bump, but this will not pass SAW's integration tests without also including the bugfix from GaloisInc/cryptol#1791. As a result, I've also included GaloisInc/cryptol#1791. GaloisInc/cryptol#1791 is latest of the three patchsets, so I have bumped the `cryptol` submodule to point to the merge commit from that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.