-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use file-embed to make TH file embedding more robust #1614
Conversation
To explain this a little better, when you open the The |
Seems like a reasonable change, removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur with @yav.
|
Haskell Language Server still struggles a bit with opening projects that are subprojects of larger projects (in the git submodule sense). When opening such projects from within their parent project, the overall project path remains the outermost one, which breaks relative paths of subprojects. The file-embed has a utility to help with such path adjustments. Theoretically, HLS will eventually support "multi-home units", where different files will be compiled under different home folders if they belong to subprojects, but in the meantime, this un-breaks HLS for users that open Cryptol as a subproject of, say, SAW.
Nice find, updated! |
I've pushed a follow-up commit to regenerate the freeze files so that |
NOTE: We don't necessarily need to merge this. It does bring up a new library and removes the
Safe
flag from the modified file. It's useful for VSCode users, and may no longer be necessary in the near-to-medium future. At least, having this branch, I can help new users who run into the same issue.Haskell Language Server still struggles a bit with opening projects that are subprojects of larger projects (in the git submodule sense).
When opening such projects from within their parent project, the overall project path remains the outermost one, which breaks relative paths of subprojects.
The file-embed has a utility to help with such path adjustments. Theoretically, HLS will eventually support "multi-home units", where different files will be compiled under different home folders if they belong to subprojects, but in the meantime, this un-breaks HLS for users that open Cryptol as a subproject of, say, SAW.