Add interface for fixed-length hash functions #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes all the hardcoded SHA-256 components (including a hardcoded maximum message width) in ECDSA - Replaces with the `HashInterface` - Updates the instantiations to use SHA-256
Renaming now that we could implement ECDSA with other hash functions -- the instantiation name needs to specify which hash is being used!
Adds a `fin` constraint to the interface to support truly arbitrary message lengths in SHA3.
mccleeary-galois
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98!
This adds a hash function interface, instantiates it with SHA and SHA3, and updates ECDSA to use it. Any further instantiations of ECDSA are punted to #104.