Make crucible:helper-tests compile with tasty-hspec-1.1.7 (#739) #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tasty-hspec-1.1.7` no longer re-exports `Test.Hspec` from `hspec`. In order to make `crucible`'s `helper-tests` work with all versions of `tasty-hspec`, this patch adds a `Test.Hspec` import. This also uses explicit imports from `Test.Tasty.Hspec` to ensure that there are no warnings when built with older versions of `tasty-hspec`. Fixes #739.
|
With this, the CI passes again, save for the macOS-specific failures observed in #741. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tasty-hspec-1.1.7no longer re-exportsTest.Hspecfromhspec. In order to makecrucible'shelper-testswork with all versions oftasty-hspec, this patch adds aTest.Hspecimport. This also uses explicit imports fromTest.Tasty.Hspecto ensure that there are no warnings when built with older versions oftasty-hspec.Fixes #739.