Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crucible: Replace viaShow with a real Pretty instance for TypeRepr #1295

Merged
merged 6 commits into from
Feb 10, 2025
Merged

crucible: Replace viaShow with a real Pretty instance for TypeRepr #1295

merged 6 commits into from
Feb 10, 2025

Conversation

langston-barrett
Copy link
Contributor

Fixes #1016.

@langston-barrett langston-barrett changed the title crucible: Replace viaShow with a real Pretty instance for TypeRepr` crucible: Replace viaShow with a real Pretty instance for TypeRepr Feb 6, 2025
@langston-barrett langston-barrett marked this pull request as ready for review February 6, 2025 20:45
RyanGlScott
RyanGlScott reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth advertising these changes in the crucible changelog, just in case anyone is relying on the precise Pretty output of a TypeRepr in their code.

crucible/src/Lang/Crucible/Types.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Types.hs Outdated Show resolved Hide resolved
RyanGlScott
RyanGlScott approved these changes Feb 7, 2025
View reviewed changes
crucible/src/Lang/Crucible/Types.hs Show resolved Hide resolved
crucible/src/Lang/Crucible/Types.hs Show resolved Hide resolved
@langston-barrett langston-barrett mentioned this pull request Feb 7, 2025
Open
@langston-barrett langston-barrett merged commit c9ddb84 into master Feb 10, 2025
24 checks passed
@langston-barrett langston-barrett deleted the jln/typereprpretty branch February 10, 2025 15:02
RyanGlScott added a commit that referenced this pull request Feb 11, 2025
@RyanGlScott
crucible-debug: Accept new test output due to changes in TypeRepr pre…
15d2327 
…tty-printing

This fixes an oversight from #1295 in which the `Pretty` instance for
`TypeRepr` was changed, but the expected test output from various
`crucible-debug` test cases (which depend on the behavior of that `Pretty`
instance) were not updated. Easily fixed.

One half of a fix for #1302.
RyanGlScott added a commit that referenced this pull request Feb 11, 2025
@RyanGlScott
crucible-debug: Accept new test output due to changes in TypeRepr pre…
ae3d6dd 
…tty-printing

This fixes an oversight from #1295 in which the `Pretty` instance for
`TypeRepr` was changed, but the expected test output from various
`crucible-debug` test cases (which depend on the behavior of that `Pretty`
instance) were not updated. Easily fixed.

Towards a fix for #1302.
@langston-barrett langston-barrett mentioned this pull request Feb 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees

@jn80842 jn80842

@langston-barrett langston-barrett

Labels
crucible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a proper pretty-printer for TypeReprs
3 participants
@langston-barrett @RyanGlScott @jn80842