server: record summarized error contents in telemetry #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, telemetry events simply encode whether the event ended in success, failure, or neither. This expands the failure outcome to represent optional, additional context about the failure, and fills it with summaries of verification failures from Cerberus and CN.
This additional context is not particularly structured - it's basically the Cerberus/CN-defined pretty-printed version of the error, as a user would see in a tooltip. For example, here's how an error summary might appear in JSON-encoded telemetry:
I don't know whether this is a sufficient substitute for properly-structured error representations. In the longer term, I imagine that telemetry consumers would benefit from more structure, but I think there's definite value in the shorter term in providing at least something other than an opaque success/failure outcome.