Allow to passthru kwargs on ssh.__getattr__ convenience function to fix SSH motd problems
#2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only passing the command arguments themselves to `ssh.system` when using `ssh.somecommand('args')`, allow to specify keyword arguments as well `ssh.somecommand('args', tty=False)`.
If the remote server is printing some motd agressively, this could lead to interpreting the motd instead of the requested output.
peace-maker
force-pushed
the
ssh_getattr_kwargs
branch
from
1693a5f to
37a6626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only passing the command arguments themselves to
ssh.systemwhen usingssh.somecommand('args'), allow to specify keyword arguments as wellssh.somecommand('args', tty=False). This can be used to avoid allocating an interactive channel with a tty when executing commands this way. This avoids receiving a motd in front of the command output.