-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): allow overriding config from environment #10
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 94.23% 94.49% +0.25%
==========================================
Files 9 9
Lines 434 454 +20
Branches 74 79 +5
==========================================
+ Hits 409 429 +20
Misses 21 21
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9edc5c8
to
54140f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review, with some typos and comment on the env var cast.
Hey! This is a very welcomed improvement, thanks! |
54140f2
to
af01f65
Compare
There it is, PR updated. On the contributing guide, this is always hard to find the right balance between being open enough for people to easily contribute and strict enough for this to be sustainable. I contribute a lot, try to follow them but I still encounter some issues sometimes so I am careful because I can understand the pressure of receiving a not welcome PR 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, sorry for the delay :)
Hello 👋🏼
First I apologize because I read the
CONTRIBUTING.md
after doing my PR so there is no open issue and no discussion for this. But any critism or refusal is welcome here 🙏🏼 (better late then never).This PR allows to override some settings (all but
dependency_mapping
) usingSYNC_PRE_COMMIT_LOCK_*
environment variables.There are multiple use case for this, but in my case I currently have 2:
Note: I plan on doing another contribution real soon, but I promise I'll open an issue before to discuss this