-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Beekeeper module not working with GT IApiary #118
Conversation
Looks like that change removes old gendustry industrial apiaries support, do I understand it right that they are no longer part of GTNH? (I didn't really follow modpack development last 2 years) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Scala code can compile totally fine with GT classes. I guess, you just tried to use instanceof
keyword (Scala doesn't have one...)
Please, make sure that mod works without GT loaded. No need in creation of additional hard dependencies. Also, instead of using implementation details of Industrial Apiary (which can be changed) it's better to create necessary methods at GT side.
If you need any help, you can ping me on Discord.
src/main/scala/li/cil/oc/integration/forestry/UpgradeBeekeeper.scala
Outdated
Show resolved
Hide resolved
src/main/scala/li/cil/oc/integration/forestry/UpgradeBeekeeperUtil.java
Outdated
Show resolved
Hide resolved
src/main/scala/li/cil/oc/integration/forestry/UpgradeBeekeeperUtil.java
Outdated
Show resolved
Hide resolved
While it seems to work still the gendustry industrial apiary no longer has a crafting recipe and is marked deprecated with a recipe to convert to the GT one, so I assumed removing the support here was fine.
Intellisense offered me some kind of |
The requested changes have been pushed. This PR now completely depends on GTNewHorizons/GT5-Unofficial#2550 |
Good job! I'll approve this PR once necessary GT tag is ready. |
Related to issue #15775 I opened, decided to try and fix it myself.
Scala wouldn't compile when BaseMetaTileEntity::getMetaTileEntity was called so all logic was deferred to a static java class.