Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Beekeeper module not working with GT IApiary #118

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

Noktuska
Copy link

Related to issue #15775 I opened, decided to try and fix it myself.
Scala wouldn't compile when BaseMetaTileEntity::getMetaTileEntity was called so all logic was deferred to a static java class.

@Dream-Master Dream-Master requested review from repo-alt and a team March 22, 2024 22:17
@repo-alt
Copy link

Looks like that change removes old gendustry industrial apiaries support, do I understand it right that they are no longer part of GTNH? (I didn't really follow modpack development last 2 years)

Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Scala code can compile totally fine with GT classes. I guess, you just tried to use instanceof keyword (Scala doesn't have one...)

Please, make sure that mod works without GT loaded. No need in creation of additional hard dependencies. Also, instead of using implementation details of Industrial Apiary (which can be changed) it's better to create necessary methods at GT side.

If you need any help, you can ping me on Discord.

@Noktuska
Copy link
Author

Looks like that change removes old gendustry industrial apiaries support, do I understand it right that they are no longer part of GTNH? (I didn't really follow modpack development last 2 years)

While it seems to work still the gendustry industrial apiary no longer has a crafting recipe and is marked deprecated with a recipe to convert to the GT one, so I assumed removing the support here was fine.

// Scala code can compile totally fine with GT classes. I guess, you just tried to use instanceof keyword (Scala doesn't have one...)

Please, make sure that mod works without GT loaded. No need in creation of additional hard dependencies. Also, instead of using implementation details of Industrial Apiary (which can be changed) it's better to create necessary methods at GT side.

If you need any help, you can ping me on Discord.

Intellisense offered me some kind of te.isInstanceOf[BaseMetaTileEntity] which worked fine, but Scala then wasn't able to compile once calling te.asInstanceOf[BaseMetaTileEntity].getMetaTileEntity because of some issue with the GT_ItemStack class. I've discussed this in the #mod-dev discord channel. I assume it is still fine to defer all functionality to java tho, as I've gathered not alot of people enjoy working with Scala.

@Noktuska
Copy link
Author

The requested changes have been pushed. This PR now completely depends on GTNewHorizons/GT5-Unofficial#2550

@OneEyeMaker
Copy link

Good job! I'll approve this PR once necessary GT tag is ready.

@Dream-Master Dream-Master merged commit 6d8e8dd into GTNewHorizons:master Mar 25, 2024
1 check passed
@Noktuska Noktuska deleted the beekeeper-fix branch March 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants