Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If we say it's thread safe, that makes it true -- right? right? #117

Merged
merged 3 commits into from
Mar 1, 2024
Merged

If we say it's thread safe, that makes it true -- right? right? #117

merged 3 commits into from
Mar 1, 2024

Conversation

mitchej123
Copy link

No description provided.

@mitchej123 mitchej123 requested a review from boubou19 February 29, 2024 03:06
@mitchej123 mitchej123 marked this pull request as draft February 29, 2024 03:29
@mitchej123
Copy link
Author

Assembler & Robots are not thread safe and use direct GL11 calls, look into either 1) making them safe 2) making a separate renderer for them

@mitchej123 mitchej123 marked this pull request as ready for review February 29, 2024 20:43
@mitchej123
Copy link
Author

@boubou19 spotted another issue and pushed a fix

@Dream-Master Dream-Master requested a review from a team March 1, 2024 06:12
boubou19
boubou19 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@boubou19 boubou19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in game, works fine now (3D prints are fixed)

@mitchej123 mitchej123 merged commit a8c255a into master Mar 1, 2024
1 check passed
@mitchej123 mitchej123 deleted the thread-safe branch March 1, 2024 20:57
@boubou19 boubou19 mentioned this pull request Aug 16, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boubou19 boubou19 boubou19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchej123 @boubou19