Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add botania into inf gear recipes #1190

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

EnderProyects
Copy link
Contributor

@EnderProyects EnderProyects commented Feb 6, 2025

Copy link
Contributor

@combusterf combusterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is disingenuous: a wide variety of items are introduced, plenty of which are not from Botania.

Also a reminder that Botania is a requirement for draconic evolution, and its technologic completion is thus already enforced.

@EnderProyects
Copy link
Contributor Author

The description is disingenuous: a wide variety of items are introduced, plenty of which are not from Botania.

Also a reminder that Botania is a requirement for draconic evolution, and its technologic completion is thus already enforced.

Every time I see someone complain about botania is because is not integrated into the pack, or because is not needed at all until Draconic crafting, my plan is to change this, and as I said in the issue better start at endgame than changing earlier recipes.
Also I included some other items because of the spots I have to remove some infinity plates, so to fill some gaps or fix symmetry

@Ruling-0
Copy link
Contributor

Ruling-0 commented Feb 6, 2025

It would be nice to include before and after images of the recipes so it's more obvious what was changed.

@Dream-Master
Copy link
Member

@EnderProyects yes add some old and new recipe pictures and we can start to discuss.

@Dream-Master Dream-Master requested a review from a team February 7, 2025 10:04
@combusterf
Copy link
Contributor

@EnderProyects The real problem is that you have made a reputation for yourself, and less about this being a beneficial change or not. I'm expecting you to be honest upfront and not do something that looks like you're trying to sneak in some extra nerfs on the side.

So do what we expect every good change request to look like: post the exact changes, and mention how you think it affects balance (including nerf, buff, etc.) Once that's done and checks out, I'll unblock my review, and if you're lucky, approve it if you managed to convince me.

@EnderProyects
Copy link
Contributor Author

Infinity helmet
image
image

Changed Sanguine helmet to terrasteel helmet, since the sanguine armour is used twice in the recipes, since all is used in the wyvern armour, is kinda a buff since replaces a blood magic armour with a botania armour piece ( just terrasteel)

Infinity breastplate
image
image

Same as above

Infinity boots
image
image

Same as above

Infinity leggins
image
image

Same as above but since is replacing two infinity plates, one of them is one of the primordial graves, is not a hard recipe so I dont see is as a nerf, more as a buff since is less infinity


Longbow of the heavens
image
image

Added crystal bow, is a very simple recipe, and since this tool doesnt have as meny tools as the others inf weapons and I needed to add some symetry for adding this bow, also added the Quantum bow from galaxy space

Nature Ruin
image
image

Added the terra truncator from botania, and for symetry for the recipe also added the primordial greataxe from Witching gatgets, both of them are not any hard to craft at the tier of inf, they just add some more integgration in doing recipes

Planet eater
image
image

Added one elementium shovel and for symetry one shovel of purity, a tool anyone could have rafted before since is very usefull

World Breaker
image
image

Replaced two neutronium large plates with one Terra Shatterer, and for symetry one chamaleon pickaxe from Forbiden magic

Sword of the cosmos
image
image

Replaced one block of cosmic neutronium with the Starcaller, and since I remove this neutronium block I upgraded the Nano saber to his advanced recipe, The Mjolnir


Crystal Studded Cosmic Neutronium Wand
image
image

Replaced the wand focus spots with wand focuses of botania, moved them to the sides replacing two inf plates, upgraded the Black hole ring to the Worldshaper, and since is less infinity added one akastic record to the wand, an item that also has its quest for inifinity, makes sense to have in the infinity wand since it gives "infinity" aspects, and looks great since the caps of the wand are blue

@Ruling-0
Copy link
Contributor

Ruling-0 commented Feb 7, 2025

Primordial leggings being the only piece of the set to show up is weird. What about instead putting the terrasteel leggings where the sigil is, and moving the sigil up one (replacing a spnt plate)?

@combusterf combusterf dismissed their stale review February 7, 2025 19:15

New information was added

@EnderProyects
Copy link
Contributor Author

Primordial leggings being the only piece of the set to show up is weird. What about instead putting the terrasteel leggings where the sigil is, and moving the sigil up one (replacing a spnt plate)?

ok ;3

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 11, 2025
@Ruling-0
Copy link
Contributor

Ruling-0 commented Feb 27, 2025

I've been thinking on this for a bit. I don't mind the gear changes but I don't like the wand update, personally. I think the recipe is just a bit uglier (misses the mapping of the recipe to the want texture) and I don't think it needs this much other stuff added. If you want to add botania cleanly to this, imo, the best would be to just replace the two inf plates at each end with elementium caps (I don't think one of each is needed, and weird since most wands don't mix the caps).

Also don't forget to put closes [issue] in the top comment so this links to your issue.

@EnderProyects
Copy link
Contributor Author

I've been thinking on this for a bit. I don't mind the gear changes but I don't like the wand update, personally. I think the recipe is just a bit uglier (misses the mapping of the recipe to the want texture) and I don't think it needs this much other stuff added. If you want to add botania cleanly to this, imo, the best would be to just replace the two inf plates at each end with elementium caps (I don't think one of each is needed, and weird since most wands don't mix the caps).

Also don't forget to put closes [issue] in the top comment so this links to your issue.

Changed as requested :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Botania into inf armour
5 participants