Fix any dimension without a sky getting flagged as the nether #857
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimension check set any dimension with no sky as the nether; this includes the end, and several custom dims such as Witchery's mirror dim, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dimensions like the End, and several modded dims (such as the last dimension, witchery's mirror dim, etc) do not have sky to avoid weather.
Because of this, every dim without a sky, including the End, was being flagged as the nether - this was messing with shaders such as Complementary that have different effects per dimension.
Adjusted the check to remove the hasNoSky check, and it fixed it.
This gets at least vanilla dims registering correctly until a dimensions.properties file is properly implemented.
Built it locally after the change, verified that it's working as intended.