Production Release #743
Merged
Production Release #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sprint 47 issues includes: Dependabot Alert: Atro CSRF Middleware Bypass (security.checkOrigin) #720 Dependabot Alert: Astro's server source code is exposed to the public if source maps are enabled #725 Update to the latest version of USWDS 3.11.0 #722 BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728 Update SMTP to reflect GSA IT naming convention standard #736
weiwang-gsa
approved these changes
Jan 23, 2025
| @@ -141,7 +147,11 @@ def get_admin_smartpay_training_report(self, filter: SmartPayTrainingReportFilte | |||
| if filter.bureau_id is not None: | |||
| query = query.filter(models.User.agency_id == filter.bureau_id) | |||
| elif filter.agency_id is not None: | |||
| query = query.filter(models.User.agency_id == filter.agency_id) | |||
| # if agency is selected and not the bureau, return all records associated to agency/bureau | |||
| all_agencies = self._session.query(models.Agency).all() | |||
There was a problem hiding this comment.
the code works, but probably direct query to get all the bureau ids that belong to selected agency id may have better performance for large data sets. Current code is pulling all agencies records to memory is not necessary. Although current agencies table is not large table, still suggest to make change when you have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprint 47 issues includes:
Dependabot Alert: Atro CSRF Middleware Bypass (security.checkOrigin) #720
Dependabot Alert: Astro's server source code is exposed to the public if source maps are enabled #725
Update to the latest version of USWDS 3.11.0 #722
BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728
Update SMTP to reflect GSA IT naming convention standard #736