Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Empty Headers and Subnav Items Update #1274

Merged
merged 17 commits into from
Jan 29, 2025

Conversation

claytonjbarnette
Copy link
Member

Minor fixes to address AAA issues flagged in SI.

Empty Headers Update

  • Fixed empty headers sitewide related to alerts (call-out-boxes): info, success, warning, errors.
  • I placed logic in the alert templates as a safeguard against empty headings, if a heading is left empty, it will not print the HTML header code on the page but will add a <br /> in its' place to preserve spacing to promote readability.

Alerts are templates included in place on a page, these alerts take parameters; for some (52), the heading were left blank. These empty headings affect the AAA score, reducing these should increase the AAA score by some measure.

Subnav Items Height Update

  • Added CSS min-height to the stylesheet (assets/css/index.scss) to restrict subnav items that appear in sidenavs from displaying smaller in height than 44px.
  • This added a small amount of spacing to the bottom of subnav items helping with readability and gives users on touch screens more area to press subnav items .
  • This should increase the AAA score by some measure.

SI was flagging any subnav items whos height was smaller than 44px in height, subnav items with more characters in their title-text normally display larger than 44px in height and were not being flagged.

Broken Links

Only two broken links are addressed in this update, but may have already been addressed in previous updates. SI may recheck and reflag these if scanned before this update goes to Prod.

@SuGhadiali
@TheInfinityBeyonder

📅 01/29/2025 👍

@JBPayne007 JBPayne007 merged commit 3c86e6e into staging Jan 29, 2025
4 checks passed
@JBPayne007 JBPayne007 deleted the 0123-eo-brkn-links-update branch January 29, 2025 16:58
@claytonjbarnette claytonjbarnette self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants