Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated identifier to guid #22

Merged
merged 6 commits into from
Nov 12, 2021
Merged

updated identifier to guid #22

merged 6 commits into from
Nov 12, 2021

Conversation

NeerajaVadlapudi
Copy link
Contributor

@NeerajaVadlapudi NeerajaVadlapudi commented Nov 9, 2021

Related to GSA/data.gov#2744

Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeerajaVadlapudi take a look at the requested changes, and grab a pair if it doesn't make sense.
Make sure you note the rebase issue; you'll revert my most recent changes if this gets merged. You should either rebase, or consider just restarting from main on a new branch since there are so many changes.

dedupe/ckan_api.py Outdated Show resolved Hide resolved
dedupe/ckan_api.py Outdated Show resolved Hide resolved
dedupe/ckan_api.py Outdated Show resolved Hide resolved
dedupe/ckan_api.py Outdated Show resolved Hide resolved
dedupe/ckan_api.py Outdated Show resolved Hide resolved
dedupe/deduper.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close!!!

dedupe/ckan_api.py Outdated Show resolved Hide resolved
dedupe/deduper.py Outdated Show resolved Hide resolved
dedupe/ckan_api.py Outdated Show resolved Hide resolved
@jbrown-xentity jbrown-xentity merged commit db53428 into main Nov 12, 2021
@jbrown-xentity jbrown-xentity deleted the change_identifier branch November 12, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants