Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBlueprint for CKAN 2.9 controllers #99

Closed
wants to merge 11 commits into from
Closed

IBlueprint for CKAN 2.9 controllers #99

wants to merge 11 commits into from

Conversation

adborden
Copy link

@adborden adborden commented May 29, 2021 •
edited
Loading

  • depends on Test fixes #97

  • Use mixin pattern for pylons->flask changes

  • Stub out controller methods

  • Move data.json export code

Aaron D Borden added 11 commits May 27, 2021 13:46
Fix nose tests
a7f45f6 
Update how we're stubbing the datajson links_enabled config for tests.
Use fcs branch for shared scripts
626a006 
catalog.data.gov main is for CKAN 2.9 and cloud.gov we should be using the
shared scripts (to be deprecated) from the fcs branch.

Remove unused inventory script.
Fix test.ini issue in new style tests
2fd2c38 
- Update test-core.ini to be the path in the okfn docker container.
- Default to CKAN_VERSION=2.8 for docker-compose
Include future in dependencies
ce4164d
Fix nose export test
36b45ef 
Use binary file object for writing zip.
Include harvest extension for some tests
2e8dde9
Typo
abf6960 
Use tee so we still see output on stdout.
Typo
6761a35 
ckanext-harvest fixture is clean_queues
Use mixin pattern for pylons->flask changes
9fc7712
Stub out controller methods
26cef42 
- Parse configuration as booleans
- Store configuration on plugin instance
- Move DataJsonController to separate file
Move data.json export code
8216fa7 
Move the export code so that it can be shared between the pylons controller and
the flask controller.
@github-actions
Copy link

github-actions bot commented May 29, 2021 •
edited
Loading

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.10-final-0 -----------

Name Stmts Miss Cover
ckanext/datajson/init.py 6 6 0%
ckanext/datajson/build_datajson.py 0 0 100%
ckanext/datajson/build_datajsonld.py 29 29 0%
ckanext/datajson/build_organizations.py 68 68 0%
ckanext/datajson/datajson_ckan_23.py 403 403 0%
ckanext/datajson/datajson_ckan_28.py 417 371 11%
ckanext/datajson/datajsonvalidator.py 221 221 0%
ckanext/datajson/exceptions.py 2 0 100%
ckanext/datajson/export.py 137 137 0%
ckanext/datajson/harvester_base.py 4 0 100%
ckanext/datajson/harvester_cmsdatanavigator.py 55 55 0%
ckanext/datajson/harvester_datajson.py 46 34 26%
ckanext/datajson/helpers.py 116 116 0%
ckanext/datajson/package2pod.py 319 319 0%
ckanext/datajson/parse_datajson.py 94 87 7%
ckanext/datajson/plugin/init.py 26 3 88%
ckanext/datajson/plugin/flask_plugin.py 11 6 45%
ckanext/datajson/plugin/pylons_plugin.py 15 15 0%
ckanext/datajson/tests/init.py 0 0 100%
ckanext/datajson/tests/conftest.py 1 0 100%
ckanext/datajson/tests/factories.py 71 36 49%
ckanext/datajson/tests/mock_datajson_source.py 75 57 24%
ckanext/datajson/tests/nose/init.py 0 0 100%
ckanext/datajson/tests/nose/factories.py 71 36 49%
ckanext/datajson/tests/nose/mock_datajson_source.py 75 57 24%
ckanext/datajson/tests/nose/test_collections_ui.py 115 93 19%
ckanext/datajson/tests/nose/test_datajson_ckan_28_harvester.py 337 328 3%
ckanext/datajson/tests/nose/test_datajson_ckan_all_harvester.py 173 134 23%
ckanext/datajson/tests/nose/test_export.py 75 55 27%
ckanext/datajson/tests/test_collections_ui.py 113 93 18%
ckanext/datajson/tests/test_datajson_ckan_28_harvester.py 337 279 17%
ckanext/datajson/tests/test_datajson_ckan_all_harvester.py 171 131 23%
ckanext/datajson/tests/test_export.py 68 51 25%
ckanext/datajson/views.py 22 6 73%
TOTAL 3673 3226 12%
FAIL Required test coverage
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors
===================== 1 warnings, 1

Base automatically changed from feature/py3 to main July 9, 2021 23:49
@nickumia-reisys
Copy link

CKAN 2.9 already supported since

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adborden @nickumia-reisys