Feature/py3 py2 conditional #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support development and testing using CKAN_VERSION make variable. Move existing legacy nose tests to docker-compose.legacy.yml and update make targets to support it.
New CI tests for CKAN 2.8 and 2.9
Update docker environment
also combined test-inventory/test_export.py in to /tests
$ pip install futurize $ futurize --both-stages --write ckanext
Clean up various test and configuration options
otherwise it used root and gives error
somehow this is not working for us config['ckanext.datajson.inventory_links_enabled'] = "True"
…kan/ckan/blob/2.9/ckan/lib/base.py); response doesn't seem to exist in ckan.plugins.toolkit, so import it from pylons again?
…t new version of 'response' to handle 'zip' files
… works without it; fixed lint
…rly; updated Makefile to point to the correct docker-compose.yml file
…was necessary; updated SQLAlchemy library calls in get_packages(..) because the package organization changed from 1.1.11 to 1.3.5
…t framework was changed in CKAN2.9 and the response is forced to be a string, so the zip file can't be sent, see https://github.com/ckan/ckan/blob/2.9/ckan/tests/helpers.py#L185-L240 vs https://github.com/ckan/ckan/blob/2.8/ckan/tests/helpers.py#L147-L159
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.8.10-final-0 -----------
|
…-compose if older..
…datajson into feature/py3-py2-conditional
…oved (maybe accidentally?)
Ignore nose tests (pre py3) in linting
…og integration test
…datajson into feature/py3-py2-conditional
jbrown-xentity
approved these changes
Jul 9, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completes the PY3 upgrade for the ckanext-datajson extension. All tests work locally. The Github Actions don't are not running correctly, @jbrown-xentity or @FuhuXia, please look to see if you see any glaring errors. The file has not been changed since it ran successfully here.
There is one dependency to successfuly merge this PR. The
test_exporttest could not be implemented properly due to a change in the way thatckan.tests.helpersimplemented theirCKANTestAppclass. The issue has been documented ckan/ckan#6225. But, in order to keep the upgrades moving, the test was decided to be re-written in a new way.Acceptance of this pull request is conditional on,