Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajax recent view #199

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Ajax recent view #199

merged 5 commits into from
Jun 20, 2024

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Jun 20, 2024

For GSA/data.gov#4708 and GSA/data.gov#4655

  • an optional ckanext.datagovtheme.js_recent_view is added. If set to true, this will turn recent count info into AJAX call.
  • add test
  • redirect / to /dataset/ with a trailing slash
  • add documentation

@FuhuXia FuhuXia requested a review from a team June 20, 2024 14:17
btylerburton
btylerburton approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

README.md Show resolved Hide resolved
ckanext/datagovtheme/fanstatic_library/scripts/popular.js Show resolved Hide resolved
@FuhuXia FuhuXia merged commit b4b1296 into main Jun 20, 2024
4 checks passed
@FuhuXia FuhuXia deleted the ajax-recent-view branch June 20, 2024 15:35
@FuhuXia FuhuXia mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuhuXia @btylerburton