Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escapes meta tags & sanititzes publisher url #197

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

btylerburton
Copy link
Contributor

@btylerburton btylerburton commented Jun 17, 2024

@btylerburton btylerburton requested a review from a team June 17, 2024 20:59
add missing sudo to Dockerfile;
downgrades Shapely to 1.x version to mitigate NumPy issues
@btylerburton
Copy link
Contributor Author

btylerburton commented Jun 17, 2024

Added my other branch update-dockerfile-and-deps with dockerfile fixes as this one now fails to build without them...

Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Any reason why we're changing from openknowledge to ckan for building the docker image?

@btylerburton
Copy link
Contributor Author

@jbrown-xentity they've deprecated the open-knowledge one https://hub.docker.com/r/openknowledge/ckan-dev

@btylerburton btylerburton merged commit aee89ad into main Jun 18, 2024
4 checks passed
@btylerburton btylerburton deleted the escape-url-descriptions branch June 18, 2024 14:27
@FuhuXia
Copy link
Member

FuhuXia commented Jun 18, 2024

catalog.data.gov is working fine with Shapely==2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML meta tag content should be escaped
3 participants