Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement link previews for catalog links on social media #192

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

robert-bryson
Copy link
Contributor

Related to GSA/data.gov#4656

@btylerburton
Copy link
Contributor

do you have a screen shot of the preview link?
and would it make sense to pipe actual title and description if page is a dataset?

@robert-bryson robert-bryson marked this pull request as ready for review April 8, 2024 20:51
@robert-bryson
Copy link
Contributor Author

robert-bryson commented Apr 8, 2024

Example on dev: https://catalog-dev-admin-datagov.app.cloud.gov/dataset/purchase-card-transactions-civilian-board-of-contract-appeals-cbca-parent (with open graph checker). The image is still being a little finicky:
image

@jbrown-xentity jbrown-xentity merged commit 82b9342 into main Apr 9, 2024
4 checks passed
@jbrown-xentity jbrown-xentity deleted the 4656_link-previews branch April 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants