4632 - Adding DAP script tag into the CKAN footer template

[dlennox24]

Solves: GSA/data.gov#4632

[btylerburton]

@FuhuXia can we add remote URL's to webassets? https://github.com/GSA/ckanext-datagovtheme/blob/main/ckanext/datagovtheme/fanstatic_library/webassets.yml

[FuhuXia]

@FuhuXia can we add remote URL's to webassets? https://github.com/GSA/ckanext-datagovtheme/blob/main/ckanext/datagovtheme/fanstatic_library/webassets.yml

Not sure, but even we can, it does not sound like a good idea to let the server fetch a remote js and bundle it. We can always let user browser to fetch it like we did in the the touchpoint form.

[btylerburton]

Good point. What template is it that handles adding the webassets to the bottom of the page? We could add it there.

[FuhuXia]

Good point. What template is it that handles adding the webassets to the bottom of the page? We could add it there.

Either that, or we can create a wrap js to $.getScript() the dap js.
So the purpose for the change is that you don't like adding an external js in the <footer> somewhere in the middle the html body?

[btylerburton]

🧹

[btylerburton]

Looks like there is a failure to find this repo for UI test though. I can help troubleshoot more when I'm back on my machine.

pull access denied for ckan/ckan-solr-dev, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

[FuhuXia]

Can you deploy the two latest changes to catalog-dev?

[tdlowden]

@FuhuXia do we need to change the branch it's merged into in order to deploy to dev?

[jbrown-xentity]

do we need to change the branch it's merged into in order to deploy to dev?

@dlennox24 @tdlowden:
You'll need to incorporate these changes into catalog.data.gov repo (see here, and will need to pull directly from this repo and branch instead of pypi, there are other examples in the requirements file). Once you have that in a branch/PR, you can push that to the develop branch using git push origin branch_name:develop, and this will use github action based on the develop branch. Let me know if we need to pair on this!

[jbrown-xentity]

Also, we'll need to bump the version of this extension in this PR before it get's merged: https://github.com/GSA/ckanext-datagovtheme/blob/main/setup.py#L13

[tdlowden]

Since @dlennox24 is not working on this til Friday but we'd like to progress, maybe we can grab some time together @jbrown-xentity. I have a conflict during pair time today but I'll check your cal!

[tdlowden]

Can confirm I see the DAP script firing in dev